Marked application/config/config.php as a configuration file in packages #1594
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a pull request! Maybe @craigcomstock can review this? |
craigcomstock
force-pushed
the
ENT-12658/master
branch
from
0468a47 to
6afff25
Compare
nickanderson
approved these changes
Aug 19, 2025
… packages To change the port, masterfiles can change these files which are distributed as part of the package so we must mark them as configuration files. cfengine/masterfiles#2987 Ticket: ENT-12658 Changelog: none
craigcomstock
force-pushed
the
ENT-12658/master
branch
from
6afff25 to
46ba411
Compare
There was a problem hiding this comment.
You think we should mark the files in share/GUI as config files? They aren't the actual files that are used by the application.
Those files should only be modified if we have defined mpf_enable_mission_portal_docroot_sync_from_share_gui.
bundle agent update_cli_rest_server_url_config
{
vars:
# Both share and live versions must be changed at once since httpd will be restarted later in the same agent run.
"mp_config_file" string => "$(cfe_internal_hub_vars.docroot)/application/config/config.php";
"mp_share_config_file" string => "$(sys.workdir)/share/GUI/application/config/config.php";
"regex_test_pattern" string => ".*localhost:$(cfe_internal_hub_vars.https_port).*";
files:
mpf_enable_mission_portal_docroot_sync_from_share_gui::
"$(mp_share_config_file)"
handle => "cfe_internal_edit_share_gui_mp_config",
edit_line => change_cli_rest_server_url_port,
if => and(
fileexists("$(mp_share_config_file)"),
islessthan(countlinesmatching("$(regex_test_pattern)", "$(mp_share_config_file)"), 1)
);
any::
"$(mp_config_file)"
handle => "cfe_internal_edit_mp_config",
edit_line => change_cli_rest_server_url_port,
if => and(
fileexists("$(mp_config_file)"),
islessthan(countlinesmatching("$(regex_test_pattern)", "$(mp_config_file)"), 1)
);
}
I was thinking that we should not mark any of the files in share/GUI as config files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to management of share/GUI and not-share/GUI of two php configuration files: cfengine/masterfiles#2988
Ticket: ENT-12658
Changelog: none